Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue where double scroll hides save button #5488

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Fix for issue where double scroll hides save button #5488

merged 6 commits into from
Dec 10, 2024

Conversation

tofarr
Copy link
Collaborator

@tofarr tofarr commented Dec 9, 2024 •
edited by github-actions bot
Loading

Fix for issue where double scroll hides save button

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

The issue is that the overflow should be hidden rather than scroll:

image

#5391

To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:ecc8144-nikolaik   --name openhands-app-ecc8144   docker.all-hands.dev/all-hands-ai/openhands:ecc8144

@tofarr tofarr marked this pull request as ready for review December 9, 2024 21:00
@neubig neubig requested a review from amanape December 10, 2024 06:24
@tofarr tofarr enabled auto-merge (squash) December 10, 2024 19:33
@tofarr tofarr merged commit 58d22a1 into main Dec 10, 2024
14 checks passed
@tofarr tofarr deleted the fix-scroll-hides-save-button branch December 10, 2024 19:50
This was referenced Dec 10, 2024
Closed
Closed
@amanape amanape mentioned this pull request Dec 12, 2024
Closed
1 task
@diwu-sf
Copy link
Contributor

diwu-sf commented Dec 14, 2024

@amanape @tofarr

This introduced a regression, it fixes the double scroll on the Workspace editor, but if you check the Jupyter tab, we lost the scroll bar there. I think the fix should be localized to just the Workspace tab vs the other tabs

@diwu-sf diwu-sf mentioned this pull request Dec 15, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanape amanape amanape approved these changes

Assignees

@amanape amanape

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tofarr @diwu-sf @amanape